From: Alex Riesen Date: Sat, 17 Nov 2007 12:23:17 GMT Subject: Re: [PATCH] Rewrite some function exit paths to avoid "unreachable code" traps Message-ID: <20071117122317.GA2716@steel.home> In-Reply-To: <200711171139.32631.robin.rosenberg.lists@dewire.com> Robin Rosenberg, Sat, Nov 17, 2007 11:39:32 +0100: > lördag 17 november 2007 skrev Alex Riesen: > > Noticed by Guido Ostkamp for Sun's Workshop cc. > > > > Originally-by: Guido Ostkamp > > Signed-off-by: Alex Riesen > > --- > > Guido Ostkamp, Fri, Nov 16, 2007 23:52:01 +0100: > > > > > > What about the xdiff/xdiffi.c problem that should also be solved? > > > > > > > Please... This just looks bad. I'm sure we'll have fixup patches on the list > to fix those gotos. > > Do we support any such stupid compiler that requires a dummy goto? It is more for the compilers we don't know about yet. Userspace programming, especially with intent to be portable, often means supporting *bugs* of the platform where it happens.