From: Christian Couder Date: Wed, 14 Nov 2007 04:50:36 GMT Subject: [PATCH] Bisect visualize: use "for-each-ref" to list all good refs. Message-ID: <20071114055036.2c5ae793.chriscool@tuxfamily.org> In bisect_visualize, "cd $GIT_DIR/refs && echo bisect/good-*" was still used instead of "git for-each-ref". This patch fix it. We now pass "refs/bisect/bad" and "--not refs/bisect/good-" instead of "bisect/bad" and "--not bisect/good-" to gitk, but it seems to work. Signed-off-by: Christian Couder --- git-bisect.sh | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/git-bisect.sh b/git-bisect.sh index 1ed44e5..8d75d91 100755 --- a/git-bisect.sh +++ b/git-bisect.sh @@ -326,8 +326,8 @@ bisect_next() { bisect_visualize() { bisect_next_check fail - not=`cd "$GIT_DIR/refs" && echo bisect/good-*` - eval gitk bisect/bad --not $not -- $(cat "$GIT_DIR/BISECT_NAMES") + not=$(git for-each-ref --format='%(refname)' "refs/bisect/good-*") + eval gitk refs/bisect/bad --not $not -- $(cat "$GIT_DIR/BISECT_NAMES") } bisect_reset() { -- 1.5.3.5.629.g807b3