From: Pierre Habouzit <madcoder@debian.org>
Date: Mon, 12 Nov 2007 12:24:23 GMT
Subject: Re: [PATCH] git-clean: Fix error message if clean.requireForce is not set.
Message-ID: <20071112122423.GB20482@artemis.corp>
In-Reply-To: <4738119F.2030901@viscovery.net>

On Mon, Nov 12, 2007 at 08:41:03AM +0000, Johannes Sixt wrote:
> Pierre Habouzit schrieb:
> >On Mon, Nov 12, 2007 at 08:27:35AM +0000, Johannes Sixt wrote:
> >>It was distracting to see this error message:
> >>
> >>    clean.requireForce set and -n or -f not given; refusing to clean
> >>
> >>even though clean.requireForce was not set at all. This patch 
> >>distinguishes
> >>the cases and gives a different message depending on whether the
> >>configuration variable is not set or set to true.
> >  Note that your patch won't apply to next as is :)
> 
> You mean because of the builtinification of git-clean? I was hoping that 
> Shawn (Bohrer) is listening and will update his patch. ;) It has the same 
> problem.

  No, afaict the builtin git-clean isn't in next yet. Though the
git-rev-parse --parseopt-ification is :)

-- 
·O·  Pierre Habouzit
··O                                                madcoder@debian.org
OOO                                                http://www.madism.org