From: Jeff King <peff@peff.net>
Date: Sun, 11 Nov 2007 08:13:05 GMT
Subject: Re: [PATCH 2/2] --pretty=format: on-demand format expansion
Message-ID: <20071111081305.GA27798@sigill.intra.peff.net>
In-Reply-To: <20071110203435.GB20592@sigill.intra.peff.net>

On Sat, Nov 10, 2007 at 03:34:35PM -0500, Jeff King wrote:

> Your solution leaves me partly disgusted at the hackishness, and partly
> delighted at the cleverness. I think the way you have coded it is quite
> clear, though, so I don't think anyone is likely to get confused reading
> it. I haven't read through it carefully yet, but a tentative Ack from
> me.

OK, I had a chance to read through your patches more carefully. Assuming
that the strbuf offset technique is acceptable (and I think it is worth
the increased speed and simplicity), they look great to me. So:

Acked-by: Jeff King <peff@peff.net>

-Peff