From: Ralf Wildenhues Date: Thu, 08 Nov 2007 21:47:36 GMT Subject: [PATCH 1/3] Avoid a few unportable, needlessly nested "...`...". Message-ID: <20071108214736.GG31439@ins.uni-bonn.de> In-Reply-To: <20071108214624.GF31439@ins.uni-bonn.de> Signed-off-by: Ralf Wildenhues --- git-rebase--interactive.sh | 2 +- git-request-pull.sh | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh index 6d14092..66c80d4 100755 --- a/git-rebase--interactive.sh +++ b/git-rebase--interactive.sh @@ -392,7 +392,7 @@ do -s|--strategy) case "$#,$1" in *,*=*) - STRATEGY="-s `expr "z$1" : 'z-[^=]*=\(.*\)'`" ;; + STRATEGY="-s "$(expr "z$1" : 'z-[^=]*=\(.*\)') ;; 1,*) usage ;; *) diff --git a/git-request-pull.sh b/git-request-pull.sh index 90d969c..068f5e0 100755 --- a/git-request-pull.sh +++ b/git-request-pull.sh @@ -25,13 +25,13 @@ headrev=`git rev-parse --verify "$head"^0` || exit merge_base=`git merge-base $baserev $headrev` || die "fatal: No commits in common between $base and $head" -url="`get_remote_url "$url"`" -branch=`git peek-remote "$url" \ +url=$(get_remote_url "$url") +branch=$(git peek-remote "$url" \ | sed -n -e "/^$headrev refs.heads./{ s/^.* refs.heads.// p q - }"` + }") if [ -z "$branch" ]; then echo "warn: No branch of $url is at:" >&2 git log --max-count=1 --pretty='format:warn: %h: %s' $headrev >&2 -- 1.5.3.5.561.g140d