From: Shawn Bohrer Date: Thu, 08 Nov 2007 05:37:50 GMT Subject: Re: [PATCH] Make git-clean a builtin Message-ID: <20071108053750.GC6768@mediacenter.austin.rr.com> In-Reply-To: <7vabppbxef.fsf@gitster.siamese.dyndns.org> On Wed, Nov 07, 2007 at 12:42:16PM -0800, Junio C Hamano wrote: > > Having said that, I do not particularly agree with the way the > new implementation resolves the existing inconsistencies. > > Wouldn't it be better to remove "dir" when the user explicitly > told you to clean "dir", with or without the trailing slash? > That's what the user asked you to do, isn't it? Yes I suppose I agree. Of course I need to spend some more time staring at the code to figure out how to do so. Perhaps I can figure out what is causing the original inconsistency in git-ls-files while I'm at it.