From: Ralf Wildenhues Date: Tue, 06 Nov 2007 20:17:08 GMT Subject: [PATCH 1/5] Avoid a few unportable, needlessly nested "...`...". Message-ID: <20071106201707.GB6361@ins.uni-bonn.de> In-Reply-To: <20071106201518.GA6361@ins.uni-bonn.de> Some shells wrongly interpret double-quote backquote double-quote nesting. OTOH, the right hand side of an assignment is never split in words, so the outer double quotes are needless there. --- git-rebase--interactive.sh | 2 +- git-request-pull.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh index 76dc679..ecc6778 100755 --- a/git-rebase--interactive.sh +++ b/git-rebase--interactive.sh @@ -391,7 +391,7 @@ do -s|--strategy) case "$#,$1" in *,*=*) - STRATEGY="-s `expr "z$1" : 'z-[^=]*=\(.*\)'`" ;; + STRATEGY="-s "`expr "z$1" : 'z-[^=]*=\(.*\)'` ;; 1,*) usage ;; *) diff --git a/git-request-pull.sh b/git-request-pull.sh index a992430..ec367d7 100755 --- a/git-request-pull.sh +++ b/git-request-pull.sh @@ -24,7 +24,7 @@ headrev=`git rev-parse --verify "$head"^0` || exit merge_base=`git merge-base $baserev $headrev` || die "fatal: No commits in common between $base and $head" -url="`get_remote_url "$url"`" +url=`get_remote_url "$url"` branch=`git peek-remote "$url" \ | sed -n -e "/^$headrev refs.heads./{ s/^.* refs.heads.// -- 1.5.3.5.561.g140d