From: Jeff King <peff@peff.net>
Date: Sun, 04 Nov 2007 05:43:06 GMT
Subject: Re: [PATCH 1/2] Added basic color support to git add --interactive
Message-ID: <20071104054305.GA13929@sigill.intra.peff.net>
In-Reply-To: <7v640ivagv.fsf@gitster.siamese.dyndns.org>

On Sat, Nov 03, 2007 at 10:36:00PM -0700, Junio C Hamano wrote:

> I think you would end up spitting out:
> 
>         COLOR something RESET LF COLOR RESET LF
> 
> instead of:
> 
> 	COLOR something RESET LF LF
> 
> when you get "something\n\n" if you did that.  Not a big deal,
> though, as at this point we would be human I/O bound.

Yes, though I wonder if the former is "more correct" in the sense that
we don't know what the attributes are doing, and maybe it matters for
them to apply to each line, whether it has text or not.

But I don't think it's possible for a blank line to actually do anything
with the attributes we're currently allowing, and we don't have any
plans to allow arbitrary terminal control codes in the color specs, so
it probably doesn't matter.

-Peff