From: Jeff King <peff@peff.net>
Date: Thu, 01 Nov 2007 04:14:08 GMT
Subject: Re: [PATCH 1/1] Add --first-parent support to interactive rebase.
Message-ID: <20071101041408.GA18646@coredump.intra.peff.net>
In-Reply-To: <7vabpyfvwp.fsf@gitster.siamese.dyndns.org>

On Wed, Oct 31, 2007 at 09:10:30PM -0700, Junio C Hamano wrote:

> I think assuming utf-8 and reencoding is actively wrong.
> Existing setups of people with names that cannot be expressed in
> ASCII would already have the commit encoding specified in the
> configuration and user.name stored in that encoding, so passing
> things through as we have always done is the right thing to do.

That will break any time somebody uses -s with a --encoding= that is
different from their usual encoding. My patch assumes the source is
utf-8, but should perhaps assume some other default encoding from the
config.

But if this is not a problem for people, I'm not going to push it. I
don't actually use any of these features; it was just something I
noticed while looking at the actual bug.

-Peff