From: Scott Parish <srp@srparish.net>
Date: Sun, 28 Oct 2007 14:39:25 GMT
Subject: Re: [PATCH 6/7] include $PATH in generating list of commands for "help -a"
Message-ID: <20071028143924.GA11693@srparish.net>
In-Reply-To: <7vk5p7v5j7.fsf@gitster.siamese.dyndns.org>

On Sun, Oct 28, 2007 at 04:32:12AM -0700, Junio C Hamano wrote:

> Scott R Parish <srp@srparish.net> writes:
> 
> > +	while (1) {
> > +		if ((colon = strchr(path, ':')))
> > +			*colon = 0;
> > +
> > +		len = list_commands_in_dir(&other_cmds, path);
> > +		longest = MAX(longest, len);
> 
> Where do we borrow this MAX() macro?
> 
> On Linux with glibc, /usr/include/sys/param.h which is included
> by git-compat-util.h (meaning, for everybody) is where we find
> it, but that somehow does not sound portable assumption.

Awesome catch

sRp

-- 
Scott Parish
http://srparish.net/