From: Alex Riesen <raa.lkml@gmail.com>
Date: Tue, 23 Oct 2007 21:12:02 GMT
Subject: Re: [PATCH trailing ws fixed] use only the PATH for exec'ing git commands
Message-ID: <20071023211202.GA729@steel.home>
In-Reply-To: <20071023040844.GQ16291@srparish.net>

Scott Parish, Tue, Oct 23, 2007 06:08:45 +0200:
> We need to correctly set up PATH for non-c based git commands. Since we
> already do this, we can just use that PATH and execvp, instead of looping
> over the paths with execve.
> 
> This patch adds a setup_path() function to exec_cmd.c, which sets
> the PATH order correctly for our search order. execv_git_cmd() is
> stripped down to setting up argv and calling execvp(). git.c's main()
> only only needs to call setup_path().
> 
> Signed-off-by: Scott R Parish <srp@srparish.net>

Acked-by: Alex Riesen <raa.lkml@gmail.com>

Don't forget to mention it needs the patch from Johannes re "deducing
exec_path from calls to git with a relative path" and your
"current_exec_path"-patch. Took me a while to figure these out...