From: Jeff King <peff@peff.net>
Date: Tue, 23 Oct 2007 03:48:30 GMT
Subject: Re: What's cooking in git/spearce.git (topics)
Message-ID: <20071023034830.GA28280@coredump.intra.peff.net>
In-Reply-To: <alpine.LFD.0.999.0710221930330.30120@woody.linux-foundation.org>

On Mon, Oct 22, 2007 at 07:32:02PM -0700, Linus Torvalds wrote:

> Your patch is better than what used to be there, but
> 
> > -			/* Already picked as a destination? */
> > +			/* Already picked as a source? */
> >  			if (!p->src_dst)
> >  				continue;
> 
> the above is wrong, the whole thing should be dropped (we *want* to be 
> able to re-use sources).

Oops, you're right. I'm not sure what I was thinking.

> Anyway, the set of fixes I sent out earlier included fixing that stupid 
> loop as one of the things.

Looks like you have made some real progress. I'll try to review your
patch tonight, and hopefully make some progress on the inexact case.

-Peff