From: Shawn O. Pearce Date: Sat, 20 Oct 2007 04:57:33 GMT Subject: Re: [PATCH] send-pack: respect '+' on wildcard refspecs Message-ID: <20071020045733.GS14735@spearce.org> In-Reply-To: <20071020042257.GA26755@coredump.intra.peff.net> Jeff King wrote: > On Fri, Oct 19, 2007 at 08:00:37PM -0500, Dan McGee wrote: > > > Turns out I didn't have GIT_EXEC_PATH set up right. Once I do that, > > everything seems to work just fine. > > > > Thanks for looking into this Jeff, and git-bisect just won me over. It > > made easy work of finding the commit that broke this. > > Huzzah, success! Shawn, this should probably go on 'maint'. Although it > is probably not high priority (it has been broken since May; I think > wildcard push refspecs must not be that common), it is a fairly trivial > fix that shouldn't impact anyone else. Yea, its already queued on maint. Both the patch and the tests are obviously correct. Its broken without the patch. Its documented/expected behavior fixed by the patch. IMHO it belongs in maint. -- Shawn.