From: Jeff King Date: Thu, 18 Oct 2007 03:00:55 GMT Subject: Re: On Tabs and Spaces Message-ID: <20071018030055.GA7218@coredump.intra.peff.net> In-Reply-To: On Wed, Oct 17, 2007 at 08:03:51PM -0700, david@lang.hm wrote: >> This might matter if I'm comparing non-diff code to diff code. But in a >> diff, _everything_ is indented by exactly one space, so it all lines up. >> Is there something I'm missing? > > if the code uses a tab and the patch uses 8 spaces the two will not line up > in the diff becouse in the diff output the tab is 'only 7 spaces; > > useing one or the other isn't the problem, it's the mixing of the two. Yes, obviously. The people who advocate mixing really _are_ objectively wrong. But I was talking about all-spaces versus all-tabs. -Peff