From: Shawn O. Pearce Date: Wed, 17 Oct 2007 04:27:24 GMT Subject: Re: [PATCH] gitweb: speed up project listing on large work trees by limiting find depth Message-ID: <20071017042724.GU13801@spearce.org> In-Reply-To: <6B74E96C-37ED-4D6A-8A98-C90B61EFA181@vicaya.com> Luke Lu wrote: > On Oct 16, 2007, at 9:00 PM, Shawn O. Pearce wrote: > > > >Thanks. I'm squashing this into your patch. I'm not sure what > >the impact is of altering $File::Find::name in the middle of the > >find algorithm and I'm not sure we want to figure that out later. > >We found out the hard way today that altering a non-local'd $_ > >in the function is what was causing the breakage. > > This is generally a good advice. But tr!/!! doesn't alter the string > at all (OK, replicates it), unless you use the /d option. tr/stuff// > is an idiom to count stuff. Check perldoc perlop for details. I don't > think it's necessary. Oh. Yea, I see what you mean now. So the bug was really that you were matching on $_ not $File::Find::name. But according to perldoc File::Find $_ and $File::Find::name are the same when no_chdir => 1 which your patch also sets. So I'm really not seeing how the updated version fixes the bug. > >diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl > >index 48e21da..9f47c3f 100755 > >--- a/gitweb/gitweb.perl > >+++ b/gitweb/gitweb.perl > >@@ -1525,7 +1525,8 @@ sub git_get_projects_list { > > # only directories can be git repositories > > return unless (-d $_); > > # don't traverse too deep (Find is super > > slow on os x) > >- if (($File::Find::name =~ tr!/!!) - > >$pfxdepth > $project_maxdepth) { > >+ local $_ = $File::Find::name; > >+ if (tr!/!! - $pfxdepth > $project_maxdepth) { > > $File::Find::prune = 1; > > return; > > } -- Shawn.