From: Johannes Sixt <johannes.sixt@telecom.at>
Date: Sun, 14 Oct 2007 09:39:31 GMT
Subject: Re: [PATCH 14/14] Use the asyncronous function infrastructure to run the content filter.
Message-ID: <200710141139.31410.johannes.sixt@telecom.at>
In-Reply-To: <Pine.LNX.4.64.0710140404480.25221@racer.site>

On Sunday 14 October 2007 05:07, Johannes Schindelin wrote:
> Hi,
>
> On Sat, 13 Oct 2007, Johannes Sixt wrote:
> >  	status = finish_command(&child_process);
> >  	if (status)
> > -		error("external filter %s failed %d", cmd, -status);
> > +		error("external filter %s failed", params->cmd);
>
> Did you mean to remove the status from the output (it should probably read
> "(exit status %d)" instead of just "%d", but an exit status can help
> identify problems, right?

Oops, that looks like an artefact. Will correct.

> > +	if (start_async(&async))
> > +		return 0;	/* error was already reported */
>
> Please write "return NULL;"

Will do.

-- Hannes