From: Jeff King Date: Sat, 13 Oct 2007 17:51:27 GMT Subject: Re: [PATCH] Color support added to git-add--interactive. Message-ID: <20071013175127.GA3183@coredump.intra.peff.net> In-Reply-To: <20071013172745.GA2624@coredump.intra.peff.net> On Sat, Oct 13, 2007 at 01:27:45PM -0400, Jeff King wrote: > I believe there are other places where the diff output is parsed, and > the colors will mess that up, too (e.g., split_hunk). All of those Oops, I see you actually dealt with those already (I just responded to your cover letter first). Though I am still concerned about the robustness of the re-parsing scheme. -Peff