From: Frank Lichtenheld <frank@lichtenheld.de>
Date: Sat, 13 Oct 2007 12:49:57 GMT
Subject: Re: [PATCH] Color support added to git-add--interactive.
Message-ID: <20071013124957.GZ31659@planck.djpig.de>
In-Reply-To: <20071013081205.GB27533@coredump.intra.peff.net>

On Sat, Oct 13, 2007 at 04:12:06AM -0400, Jeff King wrote:
> > +if ($color_config=~"true" || -t STDOUT && $color_config=~"auto") {
> 
> Shouldn't these just be 'eq' instead of a regex?

What would mean you have to chomp it first. But it should at least
be written as =~ /.../ to make it clear that using a regex was a
concious decision here and not an accident.

Gruesse,
-- 
Frank Lichtenheld <frank@lichtenheld.de>
www: http://www.djpig.de/