From: Jeff King Date: Wed, 10 Oct 2007 21:33:06 GMT Subject: Re: [PATCH] Fixed crash in fetching remote tags when there is not tags. Message-ID: <20071010213305.GB8518@sigill.intra.peff.net> In-Reply-To: <20071010212735.GB16635@steel.home> On Wed, Oct 10, 2007 at 11:27:35PM +0200, Alex Riesen wrote: > Still, I'd suggest move the test into the caller, firstly because it > is the only place that special. Also, I can't think of a proper reason Yes, I agree with that. I came very close to suggesting it in my other mail, but then realized I had never even looked at the surrounding code, and I ought not to be making assessments of how that data structure should be used. But now there are two of us. :) -Peff