From: Karl Hasselström <kha@treskal.com>
Date: Mon, 08 Oct 2007 15:34:50 GMT
Subject: Re: [StGit PATCH 6/6] Let some commands work with detached HEAD
Message-ID: <20071008153450.GA12247@diana.vm.bytemark.co.uk>
In-Reply-To: <20071008085540.9734.60137.stgit@yoghurt>

On 2007-10-08 10:55:41 +0200, Karl Hasselström wrote:

> --- a/stgit/commands/diff.py
> +++ b/stgit/commands/diff.py
> @@ -42,7 +42,7 @@ rev = '([patch][//[bottom | top]]) | <tree-ish> | base'
>  If neither bottom nor top are given but a '//' is present, the command
>  shows the specified patch (defaulting to the current one)."""
>  
> -directory = DirectoryHasRepository()
> +directory = DirectoryHasRepository(needs_current_series = False)
>  options = [make_option('-r', '--range',
>                         metavar = 'rev1[..[rev2]]', dest = 'revs',
>                         help = 'show the diff between revisions'),

This hunk shouldn't be here, since diff does use crt_series. (The
commit message also has to be modified accordingly.)

So, we don't have a single test that tries to run "stg diff". Duh.

-- 
Karl Hasselström, kha@treskal.com
      www.treskal.com/kalle