From: Frank Lichtenheld Date: Thu, 04 Oct 2007 19:25:49 GMT Subject: Re: [PATCH] t9400: Add some tests for checkout Message-ID: <20071004192549.GD31659@planck.djpig.de> In-Reply-To: On Thu, Oct 04, 2007 at 08:17:07PM +0100, Johannes Schindelin wrote: > On Thu, 4 Oct 2007, Frank Lichtenheld wrote: > > On Thu, Oct 04, 2007 at 07:24:05PM +0100, Johannes Schindelin wrote: > > > Should this not be in a test_expect_success, too? > > > > Since I do this several times and since it is easier to see what tests > > it belongs to if it isn't buried in one of them, I would say "no". > > Just to clarify: I meant making an own "test_expect_success", a la "setup" > in many other test scripts. Hmm, ok, will consider it. But as said, this should then be done for the whole file at once, so I will definetly not change this particular patch. Gruesse, -- Frank Lichtenheld www: http://www.djpig.de/