From: Martin Waitz <tali@admingilde.org>
Date: Thu, 04 Oct 2007 07:17:51 GMT
Subject: Re: [PATCH] git-init: don't base core.filemode on the ability to chmod.
Message-ID: <20071004071751.GD20800@admingilde.org>
In-Reply-To: <7vr6kbbdph.fsf@gitster.siamese.dyndns.org>

hoi :)

On Wed, Oct 03, 2007 at 11:23:22PM -0700, Junio C Hamano wrote:
> filemode = !( (st1.st_mode & S_IXUSR)
>         	/* we did not ask for x-bit -- bogus FS */
> 	    || chmod(path, st1.st_mode & S_IXUSR)
>         	/* it does not let us flip x-bit -- bogus FS */
> 	    || lstat(path, &st2)
>         	/* it does not let us read back -- bogus FS */
> 	    || (st1.st_mode == st2.st_mode)
> 	        /* it forgets we flipped -- bogus FS */
> 	    );

that looks good.

-- 
Martin Waitz