From: Pierre Habouzit <madcoder@debian.org>
Date: Sat, 29 Sep 2007 12:56:33 GMT
Subject: Re: [PATCH 1/1] --color and --no-color git-log options don't need diffs to be computed.
Message-ID: <20070929125633.GC32142@artemis.corp>
In-Reply-To: <85ve9t8wh7.fsf@lola.goethe.zz>

On Sat, Sep 29, 2007 at 12:52:36PM +0000, David Kastrup wrote:
> Pierre Habouzit <madcoder@debian.org> writes:
> 
> > Signed-off-by: Pierre Habouzit <madcoder@debian.org>
> 
> > -				if (strcmp(argv[i], "-z"))
> > -					revs->diff = 1;
> > +				revs->diff = strcmp(argv[i], "-z")
> > +					&& strcmp(argv[i], "--color")
> > +					&& strcmp(argv[i], "--no-color");
> >  				i += opts - 1;
> >  				continue;
> 
> This can clear a previously set value of revs->diff.

  Good catch, that should be |= of course.

-- 
·O·  Pierre Habouzit
··O                                                madcoder@debian.org
OOO                                                http://www.madism.org