From: Christian Couder Date: Thu, 20 Sep 2007 05:23:01 GMT Subject: [PATCH] rev-list --bisect: Fix best == NULL case. Message-ID: <20070920072301.689b96c9.chriscool@tuxfamily.org> Signed-off-by: Christian Couder --- builtin-rev-list.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) Not sure if the "if (best)" check is really needed, but it looks safer with this patch. diff --git a/builtin-rev-list.c b/builtin-rev-list.c index 899a31d..3894633 100644 --- a/builtin-rev-list.c +++ b/builtin-rev-list.c @@ -436,10 +436,10 @@ static struct commit_list *find_bisection(struct commit_list *list, /* Do the real work of finding bisection commit. */ best = do_find_bisection(list, nr, weights); - if (best) + if (best) { best->next = NULL; - - *reaches = weight(best); + *reaches = weight(best); + } free(weights); return best; -- 1.5.3.2.80.g077d6f