From: Christian Couder <chriscool@tuxfamily.org>
Date: Thu, 20 Sep 2007 04:53:26 GMT
Subject: Re: [PATCH 2/7] nfv?asprintf are broken without va_copy, workaround them.
Message-ID: <200709200653.26490.chriscool@tuxfamily.org>
In-Reply-To: <7vwsumkll8.fsf@gitster.siamese.dyndns.org>

Le jeudi 20 septembre 2007, Junio C Hamano a écrit :
> > diff --git a/exec_cmd.c b/exec_cmd.c
> > index 9b74ed2..c0f954e 100644
> > --- a/exec_cmd.c
> > +++ b/exec_cmd.c
> > @@ -97,7 +97,8 @@ int execv_git_cmd(const char **argv)
> >               tmp = argv[0];
> >               argv[0] = git_command;
> >  
> > -             trace_argv_printf(argv, -1, "trace: exec:");
> > +             trace_printf("trace: exec:");
> > +             trace_argv(argv, -1);
>
> This used to be a single call into trace.c which would format a
> single string to write(2) out.  Now these two messages go
> through separate write(2) and can be broken up.  I think the
> atomicity of the log/trace message was the primary reason the
> original had such a strange calling convention.

That's right.

Christian.