From: David Brown Date: Wed, 19 Sep 2007 19:49:44 GMT Subject: Re: [PATCH] [git-p4] Detect exec bit in more cases. Message-ID: <20070919194944.GA11271@old.davidb.org> In-Reply-To: <56b7f5510709191231g22385e32y9c34d711d65b3bb7@mail.gmail.com> On Wed, Sep 19, 2007 at 12:31:52PM -0700, Dana How wrote: >On 9/19/07, David Brown wrote: >> On Wed, Sep 19, 2007 at 09:03:50PM +0200, Simon Hausmann wrote: >> >On Wednesday 19 September 2007 20:15:03 David Brown wrote: >> >> git-p4 was missing the execute bit setting if the file had other attribute >> >> bits set. >> > >> >I'm fine with this, so unless you find a better way: >> >> Well, I just tested it, and it still doesn't work, so I need to take some >> time and try to figure out what is happening. >> >> I'm sometimes getting back 'xtext', and sometimes things like 'text+mx' >> back from perforce, so I need to read up, and really figure out what to >> look for. > >The output of "git p4 filetypes" was enough for me >when I wrote my p4 front-end to fast-import; >I never did read the p4 manual. I have a patch based on what 'p4 help filetypes'. I'm running it now on a large test repository, and I'll compare the results when it is done. Provided it works, I'll send a new patch in a little bit. David