From: J. Bruce Fields <bfields@fieldses.org>
Date: Tue, 18 Sep 2007 13:12:37 GMT
Subject: Re: [PATCH 1/3] git-apply: fix whitespace stripping
Message-ID: <20070918131237.GA12120@fieldses.org>
In-Reply-To: <86r6kw4aki.fsf@lola.quinscape.zz>

On Tue, Sep 18, 2007 at 10:55:25AM +0200, David Kastrup wrote:
> As far as I can see, this does not really work since it does not
> maintain an idea of a current column.
> 
> If you have
> 
> abcd<four spaces><tab><four spaces><tab>
> 
> then indeed the resulting conversion needs to be <tab><tab><tab>
> whereas with
> 
> abc<four spaces><tab><four spaces><tab>
> 
> the resulting conversion needs to be just <tab><tab>

Note that this code *only* handles whitespace in the initial indent;
processing stops as soon as it hits anything other than a tab or an
indent.

Given that, I believe the proposed patch is correct.  Am I missing
something else?

--b.