From: Pierre Habouzit <madcoder@debian.org>
Date: Sun, 16 Sep 2007 20:51:36 GMT
Subject: Re: [PATCH] New strbuf APIs: splice and attach.
Message-ID: <20070916205136.GE26457@artemis.corp>
In-Reply-To: <874phugy6h.fsf@mid.deneb.enyo.de>

On Sun, Sep 16, 2007 at 08:20:06PM +0000, Florian Weimer wrote:
> * Pierre Habouzit:
> 
> > +void strbuf_grow(struct strbuf *sb, size_t extra)
> > +{
> >  	if (sb->len + extra + 1 <= sb->len)
> >  		die("you want to use way too much memory");
> 
> By the way, this comparison is always false because sb->len is signed.

  News to me. Actually it's not, it's a size_t :)

-- 
·O·  Pierre Habouzit
··O                                                madcoder@debian.org
OOO                                                http://www.madism.org