From: Eric Wong <normalperson@yhbt.net>
Date: Thu, 06 Sep 2007 21:35:56 GMT
Subject: Re: [PATCH] git-svn: remove --first-parent, add --upstream
Message-ID: <20070906213556.GA21234@soma>
In-Reply-To: <20070906210155.GA20938@soma>

Eric Wong <normalperson@yhbt.net> wrote:
> Lars Hjemli <hjemli@gmail.com> wrote:
> > This makes git-svn always issue the --first-parent option to git-log when
> > trying to establish the "base" subversion branch, so the --first-parent
> > option to git-svn is no longer needed. Instead a new option, --upstream
> > <revspec>, is introduced. When this is specified the search for embedded
> > git-svn-id lines in commit messages starts at the specified revision, if
> > not specified the search starts at HEAD.
> > 
> > Signed-off-by: Lars Hjemli <hjemli@gmail.com>
> 
> Looks good to me.
> 
> Acked-by: Eric Wong <normalperson@yhbt.net>

Wait, actually.  --upstream won't ever populate the refs array in
working_head_info for dcommit (but --first-parent should be great for
that).

But the rest of the commands is fine.  I also just noticed cmd_find_rev
passes the @refs argument to working_head_info() unnecessarily.

-- 
Eric Wong