From: Alex Riesen <raa.lkml@gmail.com>
Date: Tue, 04 Sep 2007 21:38:57 GMT
Subject: Re: [RFC] Convert builin-mailinfo.c to use The Better String Library.
Message-ID: <20070904213857.GA21351@steel.home>
In-Reply-To: <46DDC500.5000606@etek.chalmers.se>

Lukas Sandström, Tue, Sep 04, 2007 22:50:08 +0200:
> Hi.
> 
> This is an attempt to use "The Better String Library"[1] in builtin-mailinfo.c
> 
> The patch doesn't pass all the tests in the testsuit yet, but I thought I'd
> send it out so people can decide if they like how the code looks.

It looks uglier, but what are measurable merits? Object code size,
perfomance hit/improvement, valgrind logs?

> -static int read_one_header_line(char *line, int sz, FILE *in)
> +static int read_one_header_line(struct bStream *in, bstring line)

Every coder has a time in his life when he writes a string library...
and a stream support for it.