From: Eric Wong <normalperson@yhbt.net>
Date: Fri, 31 Aug 2007 15:21:53 GMT
Subject: Re: Perl warning in git-svn (git v1.5.3-rc7-16-ge340d7d)
Message-ID: <20070831152153.GA30745@muzzle>
In-Reply-To: <7vveav21uv.fsf@gitster.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> wrote:
> "Robert Newson" <robert.newson@gmail.com> writes:
> 
> > The latest head of git gives me this when doing most operations, this
> > also happens with the rc7 experimental Debian package. It's annoying
> > because it prints this line hundreds of times for each call to 'log',
> > for example
> >
> > "Use of uninitialized value in string eq at blah/git/git-svn line 826."
> >
> > and this fixes it;
> 
> Curious.  I wonder how can it trigger.
> 
> Presimably, that while (<$fh>) loop is reading from git-log, and
> the first line would look like "commit [0-9a-f]{40}" and will
> set $hash, do "next".  Which means the variable should have been
> initialized by the time the part that complains about string eq
> (which I think is "if ($c && $c eq $hash)" comparison) is
> reached.

This could be a sign of a bigger problem.

Does git-log read .git/config and that could potentially change
its default output format?  A quick scan of the docs say "no".

I remember using git-rev-list in the original code because git-log was
(is still?) considered porcelain and less suitable for automated
parsing...

-- 
Eric Wong