From: Uwe Kleine-König <ukleinek@informatik.uni-freiburg.de>
Date: Thu, 23 Aug 2007 09:06:00 GMT
Subject: Re: [PATCH] Fixed non portable use of expr and removed incorrect use of test -eq for string comparison
Message-ID: <20070823090600.GB6573@informatik.uni-freiburg.de>
In-Reply-To: <7vejhvi67x.fsf@gitster.siamese.dyndns.org>

Hello Junio,

Junio C Hamano wrote:
> By the way, I do not know if the use of "which" there is
> portable.  Have Solaris folks tried this program ever?
I don't count myself to "Solaris folks", even though I still use it to
read and write my email.  But anyhow I know some of the pitfalls...

	login@~ > /bin/bash --version
	GNU bash, version 3.00.16(1)-release (sparc-sun-solaris2.10)
	Copyright (C) 2004 Free Software Foundation, Inc.

	login@~ > /bin/bash

	zeisberg@login ~$ which httpd && echo successful
	no httpd in /home/zeisberg/bin /home/zeisberg/usr/bin /opt/bin
	/usr/local/graphics/bin /usr/local/gnu/bin /usr/local/bin
	/usr/local/X11R6/bin /usr/xpg4/bin /usr/bin /usr/ccs/bin /usr/sbin
	/usr/ucb /usr/openwin/bin
	successful

That is, with httpd_only=httpd I get:

	$ if expr "z$httpd_only" : "z/" >/dev/null || \
		which $httpd_only >/dev/null
	then
		$httpd_only arg1 arg2
	fi
	bash: httpd: command not found

Best regards
Uwe

-- 
Uwe Kleine-König

If a lawyer and an IRS agent were both drowning, and you could only save
one of them, would you go to lunch or read the paper?