From: Jan Hudec <bulb@ucw.cz>
Date: Wed, 15 Aug 2007 18:22:28 GMT
Subject: Re: call external editor from git-gui?
Message-ID: <20070815182228.GA3419@efreet.light.src>
In-Reply-To: <20070814070000.GA12052@diana.vm.bytemark.co.uk>

On Tue, Aug 14, 2007 at 09:00:00 +0200, Karl Hasselström wrote:
> On 2007-08-14 00:55:11 -0400, Shawn O. Pearce wrote:
> > Spawning the user's preferred editor would be a nice way to get some
> > of that.
> 
> Mmm. I wouldn't call it a _nice_ way: popping up an external program
> just to get the right text editing behavior. More like the _only_ way,
> if the user is picky enough.

It might actually have a rather serious twist. Often the editor for
git-commit would use the terminal git-commit runs on. But for git-gui you may
not have any terminal (running git-gui from context menu of some file
manager) and even if you do, the user does not expect it to be used. So the
user may -- and quite often will -- want different editors for running from
git-gui and git-commit.

-- 
						 Jan 'Bulb' Hudec <bulb@ucw.cz>