From: Luiz Fernando N. Capitulino <lcapitulino@mandriva.com.br>
Date: Wed, 15 Aug 2007 16:17:04 GMT
Subject: Re: [PATCH 1/2] Introduces xmkstemp()
Message-ID: <20070815131704.6cb76dbe@localhost>
In-Reply-To: <1b46aba20708150811o3a6fa14ew72e925c93d158ec4@mail.gmail.com>


 Hi Carlos,

Em Wed, 15 Aug 2007 17:11:02 +0200
"Carlos Rica" <jasampler@gmail.com> escreveu:

| 2007/8/14, Luiz Fernando N. Capitulino <lcapitulino@mandriva.com.br>:
| >
| > This is a wrapper for mkstemp() that performs error checking and
| > calls die() when an error occur.
| 
| I think that it is related with the git_mkstemp() function in path.c.

 Yeah, you right.

| Perhaps we should use xmkstemp inside that function too, since
| it is only used in diff.c and after the call it also dies when fd<0.

 Actually, git_mkstemp() is also called by your builtin-verify-tag.c
program and the function which calls it (run_gpg_verify()) doesn't
die() on error.

 This series is not supposed to change programs/design behaivor,
hence I've chosen to not port the calls which doesn't explicit die
on error.

 But feel free to go ahead and port the others. ;)

-- 
Luiz Fernando N. Capitulino