From: Jeff King <peff@peff.net>
Date: Sun, 29 Jul 2007 11:38:51 GMT
Subject: Re: [PATCH] Documentation/git-diff: remove -r from --name-status example
Message-ID: <20070729113850.GA17796@coredump.intra.peff.net>
In-Reply-To: <Pine.LNX.4.64.0707291214060.14781@racer.site>

On Sun, Jul 29, 2007 at 12:14:49PM +0100, Johannes Schindelin wrote:

> How about
> 
> 	if (!rev.diffopt.quiet)
> 		rev.diffopt.recursive = 1;
> 
> instead?

Can you explain?

My assumption is that you want the diff machinery to exit as quickly as
possible. But the "recursive" option is _already_ turned on for most
output formats in that case, so I had assumed that it was the quiet
option itself which caused the early return, not a failure to set
"recursive".

If you don't want recursive set for quiet runs, I think there is an
error in diff.c, which sets the output format from quiet to NO_FORMAT
only _after_ having set recursive based on the output format.

-Peff