From: Robin Rosenberg Date: Sat, 28 Jul 2007 19:48:12 GMT Subject: Re: git-svn rebase screwing up commit messages Message-ID: <200707282148.13751.robin.rosenberg.lists@dewire.com> In-Reply-To: <7vk5skps1g.fsf@assigned-by-dhcp.cox.net> lördag 28 juli 2007 skrev Junio C Hamano: > Sean writes: > > >> Having said all that, so that the readers understand the > >> background, here is a not-so-heavily-tested patch, which might > >> help. It passes all the test suite as before, but that tells > >> how existing git-svn tests do not test many things. > >> > >> I am not considering this for inclusion right now, by the way. > > > > FWIW your patch fixed my test case here. > > Actually the patched behaviour actively encourages a bad (not in > the sense that those oneline tools will not work well, but in > the sense that these messages are reader unfriendly) practice; I > do not think what the patch did deserves to be called "fixed". git-svn should not enforce git conventions when managing commits intended for svn. Those commits should obviously follow the conventions for the target (svn) repo. -- robin