From: Matthias Lederhofer <matled@gmx.net>
Date: Thu, 26 Jul 2007 22:09:49 GMT
Subject: Re: [PATCH 3/5] Clean up work-tree handling
Message-ID: <20070726220949.GA4420@moooo.ath.cx>
In-Reply-To: <Pine.LNX.4.64.0707260729150.14781@racer.site>

I try to take a closer look at your changes tomorrow evening.  Here
are just two short things I saw while taking a short look at the
patch.

Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> +const char *get_git_work_tree(void)
> +{
> +	static int initialized = 0;
> +	if (!initialized) {
> +		work_tree = getenv(GIT_WORK_TREE_ENVIRONMENT);
> +		if (!work_tree) {
> +			work_tree = git_work_tree_cfg;
> +			if (work_tree && !is_absolute_path(work_tree))
> +			work_tree = git_path(work_tree);

A tab is missing here.

> -				fprintf(stderr, "No directory given for --work-tree.\n" );
> +				error("No directory given for --work-tree.\n");

There should probably be no '\n' at the end when the 'error' function
is used.  There are two other calls to fprintf(stderr, <error message>)
next to the one you changed, why did you change this one but not the
other ones?