From: Shawn O. Pearce Date: Thu, 19 Jul 2007 06:23:02 GMT Subject: Re: [PATCH] Add commit.editor configuration variable Message-ID: <20070719062302.GG32566@spearce.org> In-Reply-To: <47EE39C7-0D57-48EC-B5A0-C10E49997E32@apple.com> Adam Roben wrote: > On Jul 18, 2007, at 11:08 PM, Junio C Hamano wrote: > > >I do not think commit.editor is a good name. Wouldn't we want > >that customized editor for "git tag -a" as well? Probably > >core.editor would come nicely next to core.pager we already > >have. > > I considered core.editor, but if it's an editor that is *only* > used for commit messages then that seems to be a too-general name, and > something like core.commit_message_editor seemed far too long. Any > suggestions? > > I had forgotten about "git tag -a" -- I will add support for that > as well. We only launch an editor for three reasons: commit messages, tag messages and git-rebase -i. If we were to ever add a new editor using thingy, odds are the user would want the same editor by default for that too. So please, core.editor, and also use it in git-rebase--interactive. -- Shawn.