From: Sven Verdoolaege <skimo@kotnet.org>
Date: Sun, 15 Jul 2007 14:07:55 GMT
Subject: Re: [PATCH 6/6] Add git-rewrite-commits
Message-ID: <20070715140755.GG999MdfPADPa@greensroom.kotnet.org>
In-Reply-To: <7v7ip2hjna.fsf@assigned-by-dhcp.cox.net>

On Sat, Jul 14, 2007 at 12:26:01PM -0700, Junio C Hamano wrote:
> But this leads to more fundamental issues.  It is not obvious
> from the description what environment rewrite-commits runs in.

I'll try to make that more clear in the next round.

> >> +To move the whole tree into a subdirectory, or remove it from there:
> >> +
> >> +---------------------------------------------------------------
> >> +git rewrite-commits --index-filter \
> >> +	'git ls-files -s | sed "s-\t-&newsubdir/-" |
> >> +		GIT_INDEX_FILE=$GIT_INDEX_FILE.new \
> >> +			git update-index --index-info &&
> >> +	 mv $GIT_INDEX_FILE.new $GIT_INDEX_FILE'
> >> +---------------------------------------------------------------
> 
> I see only one operation in the example, and "or remove it from
> there" confuses the reader.

I found it confusing too (I copied it from the filter-branch manual).
I'll remove it.

skimo