From: Sean <seanlkml@sympatico.ca>
Date: Sun, 15 Jul 2007 16:34:22 GMT
Subject: Re: [PATCH] Add --show-size to git log to print message size
Message-ID: <20070715123422.9a431506.seanlkml@sympatico.ca>
In-Reply-To: <e5bfff550707150927l745926f0nab04ad82dff913@mail.gmail.com>

On Sun, 15 Jul 2007 18:27:41 +0200
"Marco Costalba" <mcostalba@gmail.com> wrote:

> But your scheme does not fail if the patch is not \n terminated ?

I'm pretty sure there is always a preceding end-of-line marker,
before the terminating NUL; although i haven't broken down and
read the code yet.

> It can happen if the patch adds lines at the end of a file and the
> last line is not \n terminated.
> 
> In this case your scheme seems to miss the good next revision boundary.
> 

Just tested this case here with "git log --parents --pretty=raw -z -r -p"
and git prints out: "\ No newline at end of file"  followed by a newline
and then the NUL.

Sean