From: Alex Riesen <raa.lkml@gmail.com>
Date: Sun, 15 Jul 2007 09:35:29 GMT
Subject: Re: [PATCH] Add --show-size to git log to print message size
Message-ID: <20070715093529.GD2568@steel.home>
In-Reply-To: <e5bfff550707141346q2eba4ab8ka1c85e8b5a2c1b1d@mail.gmail.com>

Marco Costalba, Sat, Jul 14, 2007 22:46:39 +0200:
> Finding the delimiting '\0' it means to loop across the whole buffers
> and _this_ is the expensive and not needed part. If just after the

It is _not_ expensive. It could be made expensive, though. By using
QString and QByteArray, for instance.

> first line would be possible to point to the beginning of the next
> revision this seeking for '\0' would be not necessary anymore.

But this will make your reading different: you have to handle the case
when the next revision is not _fully_ read in yet, but you already
know its size.

> Hope I have explained clearly enough, I have some problems writing in
> at late evening ;-)

P.S. BTW, why do you have some 20 source files marked executable in
your qgit4 repository?