From: Greg KH <greg@kroah.com>
Date: Sat, 14 Jul 2007 04:00:50 GMT
Subject: Re: [PATCH] make git-send-email.perl handle email addresses with no names when Email::Valid is present
Message-ID: <20070714040050.GA11773@kroah.com>
In-Reply-To: <20070713182818.fd37372f.sfr@canb.auug.org.au>

On Fri, Jul 13, 2007 at 06:28:18PM +1000, Stephen Rothwell wrote:
> On Thu, 12 Jul 2007 23:34:14 -0700 Greg KH <greg@kroah.com> wrote:
> >
> > On Thu, Jul 12, 2007 at 10:47:17PM -0700, Junio C Hamano wrote:
> > > Greg KH <greg@kroah.com> writes:
> > > 
> > > > When using git-send-email.perl on a changeset that has:
> > > > 	Cc: <stable@kernel.org>
> > > > in the body of the description, and the Email::Valid perl module is
> > > > installed on the system, the email address will be deemed "invalid" for
> > > > some reason (Email::Valid isn't smart enough to handle this?) and
> > > > complain and not send the address the email.
> > > 
> > > That appears to be the case.
> > > 
> > >         bad foo
> > >         bad <foo@bar.baz>
> > >         ok  foo@bar.baz
> > >         ok  Foo <foo@bar.baz>
> 
> This would be a bug in Email::Valid as it complains that the second
> address fails the rfc822 check, however rfc822 says that the "display
> name" before the '<' is optional.

I agree, do you know how to get such a fix made?

thanks,

greg k-h