From: Sven Verdoolaege <skimo@kotnet.org>
Date: Wed, 11 Jul 2007 12:08:07 GMT
Subject: Re: [PATCH] send-email: extend sanitize_address_rfc822 to do rfc2047 quoting
Message-ID: <20070711120807.GH1528MdfPADPa@greensroom.kotnet.org>
In-Reply-To: <20070711114909.GA14086@informatik.uni-freiburg.de>

On Wed, Jul 11, 2007 at 01:49:09PM +0200, Uwe Kleine-König wrote:
> Sven Verdoolaege wrote:
> > On Tue, Jul 10, 2007 at 07:02:43PM +0200, Uwe Kleine-König wrote:
> > >  	my ($recipient) = @_;
> > > -	my ($recipient_name) = ($recipient =~ /^(.*?)\s+</);
> > > +	my ($recipient_name, $recipient_addr) = ($recipient =~ /^(.*?)(\s+<.*)/);
> > > +
> > > +	if ($recipient_name && $recipient_name =~ /[^-a-zA-Z0-9!*+\/ ]/ && $recipient_name !~ /=\?utf-8\?q?.*\?=/) {
> > 
> > Why the extra test for truthness of $recipient_name ?
> 
> i.e. if the pattern doesn't match, recipient_name is undefined.

I know.  I just didn't realize git-send-email was run with -w.
Sorry for the noise.

skimo