From: しらいしななこ Date: Wed, 04 Jul 2007 23:18:27 GMT Subject: Re: [PATCH] stash: end commit log with a newline Message-ID: <200707042324.l64NOp8J019289@mi0.bluebottle.com> In-Reply-To: <20070704074444.GA5687@informatik.uni-freiburg.de> Quoting Uwe Kleine-König : > Junio C Hamano wrote: >> I noticed another thing. The entries shown in "git stash list" >> look like this: >> >> stash@{0}: js/stash: e1d32c1... Teach git-stash to "apply --index" >> stash@{1}: master: 5be6007... Rewrite "git-frotz" to "git frotz" >> stash@{2}: master: 36e5e70... Start deprecating "git-command" in favor of "git command" >> stash@{3}: master: 3b0d999... Merge branch 'jo/init' >> >> But each of the stash is _not_ about these commits, but is about >> some change that happens to be on top of them. >> >> So risking to make it a tad longer, how about doing this on top? >> >> - git update-ref -m "$msg" $ref_stash $w_commit || >> + git update-ref -m "WIP on $msg" $ref_stash $w_commit || > > I like that. I already wondered about that, too. But not as much as > thinking about an alternative. > > So: > > Acked-by: Uwe Kleine-König I am sorry to join the discussion late, but I think it is much better to let the user give a short reminder message from the command line. For example, $ git stash add customized message to stash When I say "git stash list", I want to see which branch I was on when I was in the middle of doing something, and what that something was. It is not interesting which commit on that branch I started that change from. After creating a stash without a message, and then another stash with a message, I want to see: $ git stash list stash@{0}: On master: add customized message to stash stash@{1}: WIP on master: 36e5e70... Start deprecating "git-command" in favor of "git command" -- Nanako Shiraishi http://ivory.ap.teacup.com/nanako3/ ---------------------------------------------------------------------- Free pop3 email with a spam filter. http://www.bluebottle.com/tag/5