From: Jonas Fonseca Date: Tue, 12 Jun 2007 21:51:04 GMT Subject: Re: [PATCH 1/3] refactor dir_add_name Message-ID: <20070612215104.GB21858@diku.dk> In-Reply-To: <7v7iq9lk76.fsf@assigned-by-dhcp.pobox.com> Junio C Hamano wrote Tue, Jun 12, 2007: > Anyway, it appears that Jonas picked up your patch to polish up, > so I won't touch this series until that resurfaces. My idea was to put the nr, alloc, and entries members into a separate struct dir_entry_list, which should allow the dir_add_* functions to be "united" and thus somewhat remove the need for alloc_grow. However, after spending some time on it, changing dir.nr to dir.entry_list.nr etc. reduced readability so much that I ended up trying to make other cleanups and the simplicity of the series was lost. Anyway, I don't think I can come up with a more polished version without adding a few cleanup patches along the way. So I think apart from the amended version of 3/3 I will take back my intension to polish it up. -- Jonas Fonseca