From: Jonas Fonseca Date: Mon, 11 Jun 2007 19:15:54 GMT Subject: Re: [PATCH 3/3] builtin-add: simplify (and increase accuracy of) exclude handling Message-ID: <20070611191554.GA32151@diku.dk> In-Reply-To: <20070611155425.GA9316@coredump.intra.peff.net> Jeff King wrote Mon, Jun 11, 2007: > On Mon, Jun 11, 2007 at 05:01:23PM +0200, Jonas Fonseca wrote: > > I think you could even get rid of has_ignored with something like this. > > Nope, I had originally wanted to do that, but the dir_struct.ignored > list contains _all_ ignored items, not just those that were originally > in the pathspec. The prune_ignored call sets uninteresting ones to > NULL. That function could compact the list and re-set ignored_nr, but > it doesn't currently do so. Ah, I see. > An even more elegant solution would be for read_directory to mark > whether an ignored file comes from a pathspec, or was found through > recursion. That would be more efficient, and it would remove the > prune_ignored thing, which is IMHO a little hack-ish. > > I don't have time to work on it now, but I might look at it more tonight > or tomorrow (but please, if you are interested, take a crack at it). Yes, I think it might be nice for me to do if you don't mind. I would like some more experience with the git code. Maybe even redo the whole patch series to also fix the concerns about the alloc_grow macro. -- Jonas Fonseca