From: Stephen Rothwell <git@ozlabs.org>
Date: Wed, 06 Jun 2007 03:39:15 GMT
Subject: Re: [PATCH] Remove useless uses of cat, and replace with filename arguments or redirection
Message-ID: <20070606133915.d72e4afe.git@ozlabs.org>
In-Reply-To: <46660F43.4060402@freedesktop.org>

On Tue, 05 Jun 2007 18:34:59 -0700 Josh Triplett <josh@freedesktop.org> wrote:
>
> -commits=$(cat ../revs | wc -l | tr -d " ")
> +commits=$(wc -l ../revs | tr -d " ")

This is not equivalent, you probably wanted:

commits=$(wc -l <../revs | tr -d " ")

Cheers,
Stephen Rothwell