From: Matthias Lederhofer <matled@gmx.net>
Date: Mon, 04 Jun 2007 08:44:11 GMT
Subject: Re: [PATCH] Support environment variables in config file
Message-ID: <20070604084411.GA17622@moooo.ath.cx>
In-Reply-To: <20070604072707.GE16637@admingilde.org>

Martin Waitz <tali@admingilde.org> wrote:
> Do you think the approach is ok?

Looks fine from the reading part.  Up to now
    $ git config "$key" "$value" &&
      [ "$value" = "$(git config "$key")" ] &&
      echo true
will echo true for all values (at least from the things I tried with
", \ and \n).  When interpreting $VAR this changes.  I dunno if there
are any programs out there that rely on the fact that the value you
get out of the config is exactly the same as you have put in.

> Can you see other examples where we may need $VAR support?
> Or would everybody be happy with support for ~/ in filenames?

In my config I don't even use the path to my home directory anywhere
and spontaneously I can't think of any config option for which I'd use
an environment variable as value.