From: Martin Waitz <tali@admingilde.org>
Date: Fri, 01 Jun 2007 08:36:21 GMT
Subject: Re: [PATCH] catch asciidoc failures
Message-ID: <20070601083621.GB3521@admingilde.org>
In-Reply-To: <11806790373908-git-send-email-slamb@slamb.org>

hoi :)

On Thu, May 31, 2007 at 11:23:57PM -0700, Scott Lamb wrote:
> If pipefail is available (GNU bash >= 3.00), fail when asciidoc returns
> error rather than possibly later during XSLT.

perhaps we should simply change the pipe ordering to get asciidoc
to the end of the pipeline so that all shells respect its exit code?

> --- a/Documentation/Makefile
> +++ b/Documentation/Makefile
> @@ -111,6 +111,7 @@ clean:
>  
>  %.html : %.txt
>  	rm -f $@+ $@
> +	set -o pipefail 2>/dev/null; \
>  	$(ASCIIDOC) -b xhtml11 -d manpage -f asciidoc.conf \
>  		$(ASCIIDOC_EXTRA) -o - $< | \
>  		sed -e 's/@@GIT_VERSION@@/$(GIT_VERSION)/g' >$@+

something like (untested):
	sed -e 's/@@GIT_VERSION@@/$(GIT_VERSION)/g' $< |
		$(ASCIIDOC) -b xhtml11 -d manpage -f asciidoc.conf \
			$(ASCIIDOC_EXTRA) -o $@+ -

-- 
Martin Waitz