From: Joshua N Pritikin <jpritikin@pobox.com>
Date: Fri, 25 May 2007 13:28:00 GMT
Subject: Re: [PATCH] Don't allow newlines to occur in $Id:$ collapse
Message-ID: <20070525132800.GH6667@always.joy.eth.net>
In-Reply-To: <200705251413.42389.andyparkins@gmail.com>

On Fri, May 25, 2007 at 02:13:42PM +0100, Andy Parkins wrote:
> If a newline ever made it into an repository-side expanded $Id$ field,
> the keyword would still be detected as a keyword and collapsed, before
> rexpansion, e.g.
> 
>  $Id: all of this text would be removed, even if there
>  were a newline in the middle of it$
> 
> This patch catches newlines in this case and abandons treating this as a
> keyword expansion, this text would be left untouched in the working
> checkout.

That's better but I would error out instead of silently ignoring it.
Your choice.